Thread: Cant find problem argh

Code:

#include <stdio.h>
#include <stdlib.h>
char ch;
int seconds;
int minutes;
int main(void)
{
printf("Enter M to count down from minutes or S to countdown from seconds ");
scanf("%c",ch);
if("ch==M"){
printf("Enter the amount of minutes: ");
scanf("%d",&seconds);
for(minutes=seconds*60; minutes>-1; minutes--)
if(minutes==0) printf("Count Down Complete \a \n");
}
else{
printf("Enter the amount of seconds: ");
scanf("%d",&seconds);
for(seconds = seconds; seconds>-1; seconds--)
if(seconds==0) printf("Count Down Complete \a \n");
}
system("pause");
return 0;
 
}

Does anyone see problem? IF SO I WILL LOVE YOU HAHAHAHA

I have to strain my eyes just to read your writing let alone find out whats wrong with it.

Same, jesus christ! Whatever happened to typing normally without having to use stupid colours

Originally Posted by sloppyjoe

Code:

#include <stdio.h>
#include <stdlib.h>
char ch;
int seconds;
int minutes;
int main(void)
{
  printf("Enter M to count down from minutes or S to countdown from seconds ");
  scanf("%c",ch);
  if("ch==M"){
    printf("Enter the amount of minutes: ");
    scanf("%d",&seconds);
    for(minutes=seconds*60; minutes>-1; minutes--)
      if(minutes==0) printf("Count Down Complete \a \n");
  }
  else{
    printf("Enter the amount of seconds: ");
    scanf("%d",&seconds);
    for(seconds = seconds; seconds>-1; seconds--)
      if(seconds==0) printf("Count Down Complete \a \n");
  }
  system("pause");
  return 0;
}

Does anyone see problem? IF SO I WILL LOVE YOU HAHAHAHA

Now if you post your issue maybe we could help.. Apart from your dodgy if statement that probably doesn't do what you want (since it always evaluates to true) then I don't see anything else (Because I haven't read anything else).

Code:

scanf("%c",ch);

should be

Code:

scanf("%c",&ch);

Otherwise, you'll end up with the 2 questions printed right after eachother.

Code:

if("ch==M"){

shouldn't it be

Code:

if(ch=='M'){

? Or are both possible?

You ask for the amount of minutes, yet you assign it to the variable seconds?

Code:

printf("Enter the amount of minutes: ");
    scanf("%d",&seconds);

Btw: Your countdown of seconds/minutes won't decrease each second/minute. Those for-loops will just execute as fast as your CPU allows it. You'll end up with the complete countdown list in a blink of an eye. If you want the countdown to be realistic, include a simple wait method of some kind.

Code:

#include <stdio.h>
#include <stdlib.h>
char ch;
int seconds;
int minutes;
int main(void)
{
  printf("Enter M to count down from minutes or S to countdown from seconds ");
  scanf("%c",&ch);

  if(ch=='M')
  {
        printf("Enter the amount of minutes: ");
        scanf("%d",&seconds);
        for(minutes=seconds*60; minutes>-1; minutes--)
    {
        Sleep(60000); //1 minute in milliseconds
              if(minutes==0) printf("Count Down Complete \a \n");
    }
  }
  else
  {
        printf("Enter the amount of seconds: ");
        scanf("%d",&seconds);
        for(seconds=; seconds>-1; seconds--)
    {
        Sleep(1000); //1 second in milliseconds
              if(seconds==0) printf("Count Down Complete \a \n");
    }
  }

  system("pause");
  return 0;
}

Use Sleep to make a wait time.

Originally Posted by xHalt

Code:

scanf("%c",ch);

should be

Code:

scanf("%c",&ch);

Otherwise, you'll end up with the 2 questions printed right after eachother.

Code:

if("ch==M"){

shouldn't it be

Code:

if(ch=='M'){

? Or are both possible?

You ask for the amount of minutes, yet you assign it to the variable seconds?

Code:

printf("Enter the amount of minutes: ");
    scanf("%d",&seconds);

Btw: Your countdown of seconds/minutes won't decrease each second/minute. Those for-loops will just execute as fast as your CPU allows it. You'll end up with the complete countdown list in a blink of an eye. If you want the countdown to be realistic, include a simple wait method of some kind.

tyvm and also to you toony i am not sure on how to fix colors problem i apologize this is to very help me much ty

Here is my code. It worked for me very well.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>

char ch;
int seconds;
int minutes;

int main(void)
{
  printf("Enter M to count down from minutes or S to countdown from seconds ");
    scanf("%c", &ch);

    if(ch=='M') {
        printf("Enter the amount of minutes: ");
        scanf("%d",&minutes);
        for(minutes=seconds*60; minutes>-1; minutes--) {
            Sleep(60000); //1 minute in milliseconds
            printf("%d\n", minutes);
            if(minutes==0) printf("Count Down Complete! \a \n");
        }
    }
    else if(ch == 'S') {
        printf("Enter the amount of seconds: ");
        scanf("%d",&seconds);
        for(seconds = seconds; seconds>-1; seconds--) {
            Sleep(1000); //1 second in milliseconds
            printf("%d\n", seconds);
            if(seconds==0) printf("Count Down Complete! \a \n");
        }
    }
    else {
        printf("\nPlease try it again!\n");
        main();
    }

  system("PAUSE");
  return 0;
}

Originally Posted by SiLenCe

Here is my code. It worked for me very well.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>

char ch;
int seconds;
int minutes;

int main(void)
{
  printf("Enter M to count down from minutes or S to countdown from seconds ");
    scanf("%c", &ch);

    if(ch=='M') {
        printf("Enter the amount of minutes: ");
        scanf("%d",&minutes);
        for(minutes=seconds*60; minutes>-1; minutes--) {
            Sleep(60000); //1 minute in milliseconds
            printf("%d\n", minutes);
            if(minutes==0) printf("Count Down Complete! \a \n");
        }
    }
    else if(ch == 'S') {
        printf("Enter the amount of seconds: ");
        scanf("%d",&seconds);
        for(seconds = seconds; seconds>-1; seconds--) {
            Sleep(1000); //1 second in milliseconds
            printf("%d\n", seconds);
            if(seconds==0) printf("Count Down Complete! \a \n");
        }
    }
    else {
        printf("\nPlease try it again!\n");
        main();
    }

  system("PAUSE");
  return 0;
}

dont you mean heres t00ny's code, it worked very well?

Code:

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>
char ch;
int seconds;
int minutes;
int error(void);
int main(void)
{
  printf("Enter m to count down from minutes or s to countdown from seconds\n");
    scanf("%c", &ch);
    if(ch=='m') {
        printf("Enter the amount of minutes:\n");
        scanf("%d",&minutes);
        for(minutes = minutes-1; minutes>-1; minutes--) {
            Sleep(60000); //1 minute in milliseconds
            printf("%d\n", minutes);
            if(minutes==0) printf("Count Down Complete! \a \n");
        }
    }
    else if(ch=='s') {
        printf("Enter the amount of seconds:\n");
        scanf("%d",&seconds);
        for(seconds = seconds-1; seconds>-1; seconds--) {
            Sleep(1000); //1 second in milliseconds
            printf("%d\n", seconds);
            if(seconds==0) printf("Count Down Complete! \a \n");
        }
    }
    else {
         error();
         }
    
  
  system("pause");
  return 0;
}
int error(void)
{
    printf("Error! press t to try again or x to exit\n\a");
    scanf("%c", &ch);
    if(ch=='x') {
                 printf("terminating program\n");
                 return 0;
                 }
    else if(ch=='t') main();
    else {
         error();
         }
}

thanks guys this is along with your fixes plus an error system that i believe works a tad better and so that when you choose to count down from 8 minutes it dosnt do 9 It works perfect now thank you guys

---

*
sorry for double post but now that dosnt work the error function the ending process works find but the restart process does not

Originally Posted by Sir3n

dont you mean heres t00ny's code, it worked very well?

Well I took tooney code but it's also nearly the same then sloppyjoe's code. But I added some thinks like:

Code:

 else {
        printf("\nPlease try it again!\n");
        main();
    }

and something else so I wrote that because I thought that it is my version of the code. If you compare them they are not the same so be cool...
And at least he get father with

Code:

 else {
        printf("\nPlease try it again!\n");
        main();
    }

---

* see error()