Thread: [eth32] drawing hitbox display

hey guys, im working on editing some of eth32 and i started with just a simple little thing, preset vecs...i added in other peoples vecs, just like ETPUB, ETPRO etc...

it all work fine except when i try to draw the hitbox display for "my" custom one's

the code is...

Code:

void CHitboxWindow::Display(void)
{
    if (eth32.settings.hitboxType != HITBOX_CUSTOM)
        return;

    AssignHitboxPart();

    CWindow::Display();
}

my code...

Code:

void CHitboxWindow::Display(void)
{
    if (eth32.settings.hitboxType != HITBOX_CUSTOM || HITBOX_FRECKLES)
        return;

    AssignHitboxPart();

    CWindow::Display();
}

it will compile alright but ingame it won't draw it for either, i can change HITBOX_CUSTOM to any of the presets and it will draw it but it just won't draw both of them.

Thanks

Originally Posted by FreckleS

Code:

    if (eth32.settings.hitboxType != HITBOX_CUSTOM || HITBOX_FRECKLES)
        return;

C isn't associative in its operators, so the above statement is translated as if (eth32.settings.hitboxType != HITBOX_CUSTOM) AND if (HITBOX_FRECKLES)), assuming HITBOX_FRECKLES is not zero, this last statement is simply true, hence it effectively becomes just if (eth32.settings.hitboxType != HITBOX_CUSTOM). To fix, try this

Code:

if (eth32.settings.hitboxType != HITBOX_CUSTOM && eth32.settings.hitboxType != HITBOX_FRECKLES)
        return;

i was reading about that exact same thing 4 days ago..it just didn't click...i tried && HITBOX_FRECKLES but i didn't use the eth32.setings

EDIT: oops delete this, it was a bit wrong :0

my fault, misread the Q